Add image filter to cache #372
Conversation
We don't need this. Instead, increase the cargo version from masterV2 to masterV3. The cache will won't consider files with older versions. |
|
Now get_previous_image_path returns error to the old version of cache and users will be forced to set the wallpaper again to update cache. |
LGFae
left a comment
LGFae
left a comment
There was a problem hiding this comment.
Very nice. Just two small things and we can merge this.
common/src/cache.rs
Outdated
| filepath.push(output_name); | ||
| if !filepath.is_file() { | ||
| return Ok("".to_string()); | ||
| return Ok(("Lanczos3".to_string(), "".to_string())); |
There was a problem hiding this comment.
I don't really get what this gives us. Is it just to improve the error messages?
There was a problem hiding this comment.
Yes, and it makes it easy to force swww-daemon ignore missing cache files.
|
How swww restore don't stop half done if one of the outputs don't have cache file and print name of the output for all errors |
|
Thanks! |
2 participants
I primary use pixel art wallpapers, so the default filter for all restored images was annoying.
I modified cache so it stores filter and path to image separated by '\n' (I couldn't think of anything better). It can work with old version of cache if it doesn't contain '\n' using default filter.
I also fixed a crash that occurred when using a solid color on my system (EndevourOS + Hyprland): the drawable surface required RGBA image but was only provided with RGB.
I'm still learning Rust and English is not my native language, so sorry if anything is wrong.