Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eigenvectors for demixing matrix initialization in AuxIVA or OverIVA #185

Open
aanugraha opened this issue Aug 14, 2020 · 0 comments
Open

Comments

@aanugraha
Copy link

Hi!

I'm curious about the use of eigenvectors for initializing the demixing matrix in AuxIVA or OverIVA.
To be specific, I have a concern regarding line 169, as shown in the following code snippet.

if init_eig:
# Initialize the demixing matrices with the principal
# eigenvectors of the input covariance
v, w = np.linalg.eig(Cx)
for f in range(n_freq):
ind = np.argsort(v[f])[-n_src:]
W[f, :, :] = np.conj(w[f][:, ind])

I think a transposition is missing and the line should be:

W[f, :, :] = np.conj(w[f][:, ind]).T

Using the current line of code, we face a shape mismatch problem for OverIVA but not for AuxIVA, which is misleading.

CMIIW. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant