Fix for issue #181 (PR #182)

* Changes geometry computation eps to 1e-5 
* specialized is_inside routine for Shoebox rooms

CHANGELOG.rst

@@ -15,6 +15,12 @@ Bugfix
 ~~~~~~
 
 - Fixes the Dockerfile so that we don't have to install the build dependencies manually
+- Change the eps for geometry computations from 1e-4 to 1e-5 in ``libroom``
+
+Added
+~~~~~
+
+- A specialized ``is_inside`` routine for ``ShoeBox`` rooms
 
 `0.4.1`_ - 2020-07-02
 ---------------------
@@ -28,7 +34,7 @@ Bugfix
 - Adds the pyproject.toml file in MANIFEST.in so that it gets picked up for packaging
 
 Added
-~~~~~~~
+~~~~~
 
 - Minimal `Dockerfile` example.
 

pyroomacoustics/libroom_src/libroom.cpp

@@ -39,7 +39,7 @@
 
 namespace py = pybind11;
 
-float libroom_eps = 1e-4;  // epsilon is set to 0.1 millimeter (100 um)
+float libroom_eps = 1e-5;  // epsilon is set to 0.1 millimeter (100 um)
 
 
 PYBIND11_MODULE(libroom, m) {

pyroomacoustics/room.py

@@ -2155,6 +2155,8 @@ def is_inside(self, p, include_borders=True):
                 else:
                     return False
 
+        return False
+
         # We should never reach this
         raise ValueError(
             """
@@ -2521,11 +2523,26 @@ def extrude(self, height):
         self.shoebox_dim = np.append(self.shoebox_dim, height)
 
     def get_volume(self):
-
         """
         Computes the volume of a room
-        :param room: the room object
-        :return: the volume in cubic unit
+
+        Returns
+        -------
+        the volume in cubic unit
         """
 
         return np.prod(self.shoebox_dim)
+
+    def is_inside(self, pos):
+        """
+        Parameters
+        ----------
+        pos: array_like
+            The position to test in an array of size 2 for a 2D room and 3 for a 3D room
+
+        Returns
+        -------
+        True if ``pos`` is a point in the room, ``False`` otherwise.
+        """
+        pos = np.array(pos)
+        return np.all(pos) >= 0 and np.all(pos <= self.shoebox_dim)