Update definition of Flattened Gaussian to include both NF and FF #363
+207
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
rob-shalloo
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…lasy into flattenedGaussianNF
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…lasy into flattenedGaussianNF
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…lasy into flattenedGaussianNF
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…lasy into flattenedGaussianNF
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
rob-shalloo
changed the title
for more information, see https://pre-commit.ci
MaxThevenet
reviewed
Mar 19, 2025
| of or has been directly propagated from the focus. In this case there | ||
| can be a large defocus in the spatial phase. | ||
|
|
||
| w : float (in meter) |
There was a problem hiding this comment.
Is there a reason to change the name w0?
Comment on lines
+71
to
+74
| Options: 'nearfield', when the beam is defined far from focus and | ||
| has been collimated, or 'farfield', when the beam is in the vicinity | ||
| of or has been directly propagated from the focus. In this case there | ||
| can be a large defocus in the spatial phase. |
There was a problem hiding this comment.
I find this slightly misleading, just tried to help clarify, let me know what you think.
Suggested change
| Options: 'nearfield', when the beam is defined far from focus and | |
| has been collimated, or 'farfield', when the beam is in the vicinity | |
| of or has been directly propagated from the focus. In this case there | |
| can be a large defocus in the spatial phase. | |
| Options: 'nearfield', when the beam is defined far from focus (e.g., right before the focusing optics), or 'farfield', when the beam is in the vicinity of the focus. |
Comment on lines
94
to
+102
| Warnings | ||
| -------- | ||
| In order to initialize the pulse out of focus, you can either: | ||
|
|
||
| - Use a non-zero ``z_foc`` | ||
| - Use ``z_foc=0`` (i.e. initialize the pulse at focus) and then call | ||
| ``laser.propagate(-z_foc)`` | ||
| In order to initialize the pulse in the far field but out of focus, you | ||
| must select ``field_type == 'farfield'`` and then you can either: | ||
|
|
||
| - Use a non-zero ``z_foc``. | ||
| - Use ``z_foc=0`` (i.e., initialize the pulse at focus) and then call | ||
| ``laser.propagate(-z_foc)``. |
There was a problem hiding this comment.
This profile is independent of the propagator, I think this whole warning should be dropped. It says something true, but not required here. I understand this was not introduced in this PR.
Comment on lines
50
to
52
| E(x,y,z=\infty) \propto | ||
| \exp\left(-\frac{(N+1)r^2}{w(z)^2}\right) | ||
| \sum_{n=0}^N \frac{1}{n!}\left(\frac{(N+1)\,r^2}{w(z)^2}\right)^n |
There was a problem hiding this comment.
I find this expression with w(z) confusing, as we're talking about a collimated beam. I would call it R or W or something, and drop the (z) as well as the definition of w(z) below, as I do not think it is used when defined in the near field. This would require more changes in the inputs description below.
Comment on lines
+60
to
+63
| - Note that a beam defined using the near field definition would be | ||
| equivalent to a beam defined with the corresponding parameters in | ||
| the far field, but without the parabolic phase arising from being | ||
| defined far from the focus. |
There was a problem hiding this comment.
Good to have this note here indeed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Alberto's recent addition of a flattened Gaussian beam to include the case where the beam is defined in the nearfield, compared to only defining in the far field.
Addresses #354