Skip to content

Conversation

@Siel
Copy link
Member

@Siel Siel commented Oct 17, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 17, 2025 16:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the CHECKBIG convergence metric from Fortran NPAGFULLA, which measures parameter stability by calculating the median of relative parameter changes across support points. While the metric is calculated and logged, the convergence criterion continues to use the standard f1-f0 difference approach.

Key changes:

  • Implemented calculate_checkbig() function to compute median relative parameter changes
  • Added theta_old field to track previous iteration's theta values
  • Enhanced convergence logging to display both f1-f0 and CHECKBIG metrics for diagnostics

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

🐰 Bencher Report

Branchcheckbig
Testbedrust-loki
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
seconds (s)
(Result Δ%)
Upper Boundary
seconds (s)
(Limit %)
bimodal_ke_npag📈 view plot
🚷 view threshold
44.12 s
(+20.20%)Baseline: 36.71 s
47.87 s
(92.16%)
bimodal_ke_npod📈 view plot
🚷 view threshold
60.77 s
(+24.42%)Baseline: 48.84 s
68.68 s
(88.48%)
bimodal_ke_postprob📈 view plot
🚷 view threshold
20.68 s
(+22.86%)Baseline: 16.83 s
23.25 s
(88.97%)
🐰 View full continuous benchmarking report in Bencher

@mhovd mhovd changed the title add the checkbig convergence criteria feat: Add the checkbig convergence criteria Nov 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

🐰 Bencher Report

Branchcheckbig
Testbedrust-moan
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
seconds (s)
(Result Δ%)
Upper Boundary
seconds (s)
(Limit %)
bimodal_ke_npag📈 view plot
🚷 view threshold
18.75 s
(-23.53%)Baseline: 24.51 s
30.08 s
(62.31%)
bimodal_ke_npod📈 view plot
🚷 view threshold
10.41 s
(-0.49%)Baseline: 10.47 s
10.70 s
(97.37%)
bimodal_ke_postprob📈 view plot
🚷 view threshold
3.46 s
(-0.18%)Baseline: 3.47 s
3.54 s
(97.73%)
🐰 View full continuous benchmarking report in Bencher

@mhovd
Copy link
Collaborator

mhovd commented Nov 8, 2025

The tests are failing because the medians are stabilized long before the likelihood converges. I think we really need to think this criteria through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants