Skip to content

v4.0.0 #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 87 commits into
base: master
Choose a base branch
from
Open

v4.0.0 #78

wants to merge 87 commits into from

Conversation

KyleRoss
Copy link
Owner

@KyleRoss KyleRoss commented Nov 17, 2021

CAUTION!

This branch and release (@beta) is under heavy development. This exists for testing and anyone who is willing to help out with testing. DO NOT USE IN PRODUCTION!

If you do decide to try out this brand new version of LambdaLog, please report any issues you face as I can only catch so much. Any help would be greatly appreciated, especially if you are more versed in TypeScript than I am!

What's new?

This is the next major release of LambdaLog (v4.0.0) which contains many major breaking changes, new features, and TypeScript support.

Breaking Changes

  • Complete rewrite of most of the core functionality into TypeScript.
  • Custom Log Levels has been removed.
  • Log levels are now hardcoded and cannot be changed. This greatly simplifies the code and allows us to support TypeScript.
  • Use of Symbol has been removed along with any static properties on the classes to retrieve the symbols.
  • The debug option has been removed.
  • The default key name for levelKey has changed from _logLevel to __level.
  • The default key name for tagsKey has changed from _tags to __tags.
  • The shortcut log methods are now hardcoded instead of dynamically generated.
  • Removed addLevel() method from LambdaLog class.
  • Removed isError() and stubError() static methods from the LogMessage class and moved them into utility functions.
  • Environment variables that configure different options now take precedence over locally configured options.
  • Internally used properties on the LogMessage class have been renamed.

New Features

  • You can now configure the verbosity of your log messages through the new level option or LAMBDALOG_LEVEL env variable.
  • Added fatal and trace log levels.
  • Added onParse option that allows for custom parsing of log messages.
  • Added onCompile option that allows for custom structuring of the object that is logged to the console.
  • Added onFormat option that allows for custom formatting of the logged message. This gives the ability to render log messages in any format, not just JSON. (Disable JSON logging for development #75)
    • Added clean formatter that logs a message in a readable format.
    • Added minimal formatter that logs a message in a readable format without tags and metadata.
    • Ability to provide your own custom formatter as a function.
  • Added ability to configure the level, dev, and silent options via environment variables.
  • Full written in TypeScript with complete type definitions. (Provide Official Type Definitions #63, Rewrite LambdaLog using TypeScript #64)
  • The package now provides an ESM and CommonJS version to support your project.

Fixes

Misc. Changes

  • Rewrote most tests into TypeScript and still maintaining 100% coverage.

What's left?

It has been a pretty large undertaking for me, but one that this package desperately needed. This was my first real dive into TypeScript, so I'm sure there are things than can be written better. If there is anyone with more advanced TypeScript knowledge, I'm in great need of someone who can review the code and suggest any changes or help refactor the code to get this production-ready. (I'll even add you as a maintainer!)

  • Testing package implementation in Node for both vanilla JavaScript and TypeScript.
  • Testing ESM support with Node and ensuring CommonJS works correctly as well.
  • Ensuring the end-user has access to all the proper files and functionality.
  • Documentation.

Release Date

As much as I am trying to rush this out the door to get these features in the hands of all you awesome developers/engineers, I'm also limited on time (eg. I'm currently writing this documentation at midnight knowing that I have to wake up at 5:30am). Not only that, but I want to ensure I ship this next version of LambdaLog with performance, features, and stability in mind. I hope this will be the last major version for awhile.

Enough with all of that cheesy sob-story, let's talk about when this will be released, well, what I'm aiming for at this point. I hope to finish up most of my to-do list in the next couple of weeks and try to solicit some outside help for testing/analysis. Once that is complete, I hope to get this released as the latest stable version towards the end of 2021 or at the beginning of 2022. That's not guarantee at this point, but it will definitely be feasible if anyone in the community can help out!

@KyleRoss KyleRoss added this to the v4.0.0 milestone Nov 17, 2021
@KyleRoss KyleRoss self-assigned this Nov 17, 2021
@vercel
Copy link

vercel bot commented Nov 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kross/lambda-log/8hPGLWAHiyoZRWx7NMb6RJyFGEYG
✅ Preview: https://beta.lambdalog.dev

@github-actions
Copy link

github-actions bot commented Nov 17, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

# [4.0.0-beta.1](v3.2.0...v4.0.0-beta.1) (2021-11-17)

### Features

* 4.0.0-beta ([fe34fe6](fe34fe6))

### BREAKING CHANGES

* This is the beta version for the next major release of LambdaLog. Do not use in production yet! Please report any issues you may find!
* @param {Tag[]} [tags] Additional tags to append to this log.
* @returns {LogMessage} Returns instance of LogMessage.
*/
trace<T extends Message = Message>(msg: T, meta?: Metadata, tags?: Tag[]): LogMessage {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 7 locations. Consider refactoring.

* @param {Tag[]} [tags] Additional tags to append to this log.
* @returns {LogMessage} Returns instance of LogMessage.
*/
debug<T extends Message = Message>(msg: T, meta?: Metadata, tags?: Tag[]): LogMessage {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 7 locations. Consider refactoring.

* @param {Tag[]} [tags] Additional tags to append to this log.
* @returns {LogMessage} Returns instance of LogMessage.
*/
info<T extends Message = Message>(msg: T, meta?: Metadata, tags?: Tag[]): LogMessage {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 7 locations. Consider refactoring.

* @param {Tag[]} [tags] Additional tags to append to this log.
* @returns {LogMessage} Returns instance of LogMessage.
*/
log<T extends Message = Message>(msg: T, meta?: Metadata, tags?: Tag[]): LogMessage {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 7 locations. Consider refactoring.

* @param {Tag[]} [tags] Additional tags to append to this log.
* @returns {LogMessage} Returns instance of LogMessage.
*/
warn<T extends Message = Message>(msg: T, meta?: Metadata, tags?: Tag[]): LogMessage {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 7 locations. Consider refactoring.

* @param {Tag[]} [tags] Additional tags to append to this log.
* @returns {LogMessage} Returns instance of LogMessage.
*/
error<T extends Message = Message>(msg: T, meta?: Metadata, tags?: Tag[]): LogMessage {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 7 locations. Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Dec 10, 2021

Code Climate has analyzed commit 1e5076c and detected 7 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 7

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 100.0%.

View more on Code Climate.

# [4.0.0-beta.5](v4.0.0-beta.4...v4.0.0-beta.5) (2021-12-10)

### Bug Fixes

* add generic support to LogMessage class for specifying the message type ([6e6775a](6e6775a))
* add generic to LogObject type to specify type of Message ([cd1c746](cd1c746))
* explicitly set type to `string[]` for compiled tags returned from LogMessage ([fd873e3](fd873e3))
* remove generic from Message type ([cc10311](cc10311))
* remove toJSON() method from LogMessage since it's been moved to a formatter ([36fbdaa](36fbdaa))
* rename the `log` method to `_log` ([7317bf5](7317bf5))
* still generate the log message just don't log it when verbosity is set ([6e13564](6e13564))
* ts generics and typings on shortcut methods ([7e48904](7e48904))

### Features

* add `log` shortcut method as an alias for `info` to match the `console` pattern ([a3c1f16](a3c1f16))
* separate built-in formatters into separate files ([f8ecac7](f8ecac7))
@PeterBurner
Copy link

@KyleRoss do you still plan on working on this?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aruizca
Copy link

aruizca commented Feb 21, 2023

Hi! Is this release planned to happen still?

@cldsnchz
Copy link

cldsnchz commented Dec 9, 2023

Hi @KyleRoss, is this project still active?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants