Properly declare variables in mediaboxAdv.js #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mediaboxAdvanced uses some variables which are not declared properly: container and closeLink. This can cause issues if this are used elsewhere. In my case container is used as an id in my template which caused issues in IE.
|
Do-you have submitted the fix to the author of mediaboxadv ? |
|
Yep, see iaian7/mediaboxAdvanced#21. However there is also a similar PR which is over a year old: iaian7/mediaboxAdvanced#14 The latest activity on the repo is over 2 years old. To me it looks like it's no longer in active development. |
mahagr
added a commit
that referenced
this pull request
Jul 28, 2013
Properly declare variables in mediaboxAdv.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mediaboxAdvanced uses some variables which are not declared properly: container and closeLink. This can cause issues if this are used elsewhere.
In my case container is used as an id in my template which caused issues in IE.