Skip to content

Flake. Patch instead of update to avoid conflict. #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged

Conversation

david-martin
Copy link
Member

Example of failure https://github.com/Kuadrant/kuadrant-operator/actions/runs/16468002376/job/46550078139

  [FAILED] Expected success, but got an error:
      <*errors.StatusError | 0xc0003f45a0>: 
      Operation cannot be fulfilled on kuadrants.kuadrant.io "kuadrant-sample": the object has been modified; please apply your changes to the latest version and try again
      {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "Operation cannot be fulfilled on kuadrants.kuadrant.io \"kuadrant-sample\": the object has been modified; please apply your changes to the latest version and try again",
              Reason: "Conflict",
              Details: {
                  Name: "kuadrant-sample",
                  Group: "kuadrant.io",
                  Kind: "kuadrants",
                  UID: "",
                  Causes: nil,
                  RetryAfterSeconds: 0,
              },
              Code: 409,
          },
      }
  In [BeforeEach] at: /home/runner/work/kuadrant-operator/kuadrant-operator/tests/istio/limitador_istio_integration_reconciler_test.go:160 @ 07/23/25 10:34:20.309

@david-martin david-martin requested a review from a team as a code owner July 23, 2025 13:24
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.13%. Comparing base (49b1ba5) to head (959a630).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1450      +/-   ##
==========================================
- Coverage   77.58%   75.13%   -2.46%     
==========================================
  Files         101      102       +1     
  Lines       10075    10145      +70     
==========================================
- Hits         7817     7622     -195     
- Misses       1934     2200     +266     
+ Partials      324      323       -1     
Flag Coverage Δ
bare-k8s-integration 20.67% <ø> (-0.25%) ⬇️
controllers-integration 59.78% <ø> (-0.35%) ⬇️
envoygateway-integration 34.85% <ø> (+0.03%) ⬆️
gatewayapi-integration 16.70% <ø> (-0.25%) ⬇️
istio-integration 45.76% <ø> (-0.28%) ⬇️
unit 21.50% <ø> (-2.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api (u) 74.40% <100.00%> (ø)
internal (u) 77.40% <91.42%> (-2.45%) ⬇️
pkg (u) 34.33% <ø> (-8.37%) ⬇️

see 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-martin david-martin added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit 5233c4a Jul 23, 2025
40 checks passed
@david-martin david-martin deleted the fix-flake branch July 23, 2025 15:02
@github-project-automation github-project-automation bot moved this to Done in Kuadrant Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants