respect :color option in show and print#53
Open
Roger-luo wants to merge 1 commit intoKristofferC:masterfrom
Open
respect :color option in show and print#53Roger-luo wants to merge 1 commit intoKristofferC:masterfrom
Roger-luo wants to merge 1 commit intoKristofferC:masterfrom
Conversation
Owner
|
Maybe we should go for a breaking version where we fix the bad behavior (make it only print if color is specified etc). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just one small step towards solving #47 now turning
:color=>falseis at least making some examples (except string interp) print without color.