Fix jupyter logger #1361
Fix jupyter logger #1361
Conversation
| @@ -67,7 +72,7 @@ internal class IntegrationGeo : JupyterIntegration() { | |||
| val generatedDf = execute( | |||
| codeWithTypeCastGenerator = replCodeGeneratorImpl.process(geo.df, kProperty), | |||
| expression = "(${kProperty.name}.df as DataFrame<*>)", | |||
| ) | |||
| ).let { "`" + it.toString() + "`" } | |||
There was a problem hiding this comment.
"`$it`" is a bit shorter ;P
But what does this do? It renders the DF as string and adds crs? Isn't it better to output the DF natively and output CRS as string?
There was a problem hiding this comment.
What do you mean by "this"?
FieldHandlerFactory.createUpdateExecution<GeoDataFrame<*>> adds inner df schema retrieving for jupuyter.
new render section adds a new render for geodf like that:
There was a problem hiding this comment.
Nice :)
Is it always static, though? or is that just your screenshot?
There was a problem hiding this comment.
I'm wondering, should this be a separate module? I think it can just be part of the dataframe-jupyter module, potentially with the useExperimentalGeo flag
There was a problem hiding this comment.
dataframe-geo is really heavy and I wouldn't like it to be a part of general dataframe artifact, neither %use dataframe in notebooks. So I'd really like to keep them separate
| @@ -0,0 +1,8 @@ | |||
| ## This file must *NOT* be checked into Version Control Systems, | |||
There was a problem hiding this comment.
Need to remove this file :D
|
What changes in terms of setup? I reckon previously we could |
|
@koperagen as I said above, I'd like to remove |
|
Removed with the latest commit |
| @@ -169,11 +168,6 @@ internal class Integration(private val notebook: Notebook, private val options: | |||
| if (enableExperimentalCsv?.toBoolean() == true) { | |||
| println("CSV module is already enabled by default now.") | |||
| } | |||
| if (enableExperimentalGeo?.toBoolean() == true) { | |||
| println("Enabling experimental Geo module: dataframe-geo") | |||
There was a problem hiding this comment.
instead of completely removing it, please provide a helpful message of what to do instead :)
We mentioned the enableExperimentalGeo in some release, so if it suddenly does nothing anymore, people will be confused
| @@ -54,6 +54,11 @@ internal class IntegrationGeo : JupyterIntegration() { | |||
| useSchema<WithMultiLineStringGeometry>() | |||
| } | |||
|
|
|||
| render<GeoDataFrame<*>> { | |||
| println("GeoDataFrame with ${it.crs?.name?.code} CRS and inner dataframe:") | |||
There was a problem hiding this comment.
It's not ideal, better use notebook.display("text") for such things. Reason: we can't guarantee standard stream sync in multithreading envs.
Fixes #1155 + geodataframe jupyter fix + new geo-jupyter module