Version overloading #423
Open
Version overloading #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
udalov
reviewed
Jun 19, 2025
proposals/version-overloading.md
Outdated
| Any leading zeroes within the integer parts are ignored, such that `1.02` == `1.2`. | ||
| Version strings that do not match this format are reported as an error. | ||
| Version strings are parsed using the [Apache Maven comparable version](https://maven.apache.org/ref/3.5.2/maven-artifact/apidocs/org/apache/maven/artifact/versioning/ComparableVersion.html), | ||
| which is [already implemented in the Kotlin compiler](https://github.com/JetBrains/kotlin/blob/d2966040c414579bb393c3fbcd517eb27f040efb/compiler/util/src/org/jetbrains/kotlin/config/MavenComparableVersion.java). |
There was a problem hiding this comment.
The word "implemented" is a bit weird here because MavenComparableVersion.java is just taken verbatim from the Maven project. (Also in the "Semver-like version number" section)
There was a problem hiding this comment.
Btw, MavenComparableVersion.java hasn't been updated for 9 years since it was originally copied from the Maven project, so if there are any bug fixes or behavior changes there, probably we need to update it with a newer version.
There was a problem hiding this comment.
because MavenComparableVersion.java is just taken verbatim
Ah okay, somehow I missed this.
we need to update it with a newer version.
Got it, I will note this for the implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments here are for minor corrections to the text itself.
The discussion about this feature is in #431.