style: relax insert_final_newline rule in .editorconfig to avoid unwanted diffs #14651
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR relaxes the
insert_final_newline
rule in.editorconfig
by unsetting it. This helps avoid unnecessary diffs when using editors that automatically insert a final newline, especially in files that previously did not end with one.Why it's needed
Currently,
.editorconfig
enforcesinsert_final_newline = true
, but many Lua and other project files don’t follow this rule. Editors that respect.editorconfig
add a newline automatically, creating unwanted diffs.Relaxing this rule and optionally enforcing it using a linter like
editorconfig-checker
in CI would ensure better consistency and avoid accidental formatting changes during contributions.Additional context
Related to the discussion started by @spacewander.
Happy to make further adjustments if needed.
Summary
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]