Skip to content

fix(grpc): Fix error "proto3 disallow 'optional' label" #14426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

fix(grpc): Fix error "proto3 disallow 'optional' label" #14426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/unreleased/kong/fix-missing-grpc-optional-support.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
message: Fixed an issue where gRPC plugins lack support for "optional".
scope: Plugin
type: bugfix
1 change: 1 addition & 0 deletions kong/tools/grpc.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ function _M.new()
protoc_instance:addpath(v)
end
protoc_instance.include_imports = true
protoc_instance.proto3_optional = true

return setmetatable({
protoc_instance = protoc_instance,
Expand Down
2 changes: 1 addition & 1 deletion spec/fixtures/grpc/targetservice.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ service Bouncer {

message HelloRequest {
string greeting = 1;
bool boolean_test = 2;
optional bool boolean_test = 2;
}

message HelloResponse {
Expand Down
Loading