-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clustering/sync): flatten and report validation error #14262
Conversation
We should open a same PR in CE. |
this is a CE pr now |
For pre-running ee test cases, see this pr: https://github.com/Kong/kong-ee/pull/11363 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is good enough, need another reviewer to confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no e
,
is latest_version
-- example: { version = <latest version of deltas>, error = <flatten error>, } | ||
manager.callbacks:register("kong.sync.v2.notify_validation_error", function(node_id, msg) | ||
ngx_log(ngx_DEBUG, "[kong.sync.v2] received validation error") | ||
-- TODO: We need a better error handling method, it might report this error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we associate the error with a specific call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we could. but it might be a TODO ticket later. Need to have an idea how to recover this with our product manager.
all fixed. |
example that cp received from dp, the payload is as follows:
|
Summary
kong.sync.v2.notify_validation_error
(spec: https://github.com/Kong/openrpc_specfiles/pull/18/)Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-6351 KAG-5898 KAG-6381