feat(clustering/rpc): connection lost event #14257
Open
+12
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Precondition for KAG-6178
github-actions
bot
added
core/clustering
size/S
cherry-pick kong-ee
StarlightIbuki
added
skip-changelog
and removed
core/clustering
size/S
cherry-pick kong-ee
chronolaw
reviewed
Feb 11, 2025
| @@ -605,16 +605,16 @@ function _M:connect(premature, node_id, host, path, cert, key) | |||
| local meta_cap = resp_headers["sec_websocket_protocol"] | |||
|
|
|||
| if meta_cap ~= RPC_META_V1 then | |||
| ngx_log(ngx_ERR, _log_prefix, "did not support protocol : ", meta_cap) | |||
| err = "did not support protocol : " .. (type(meta_cap) == "string" and meta_cap or "unknown") | |||
| c:send_close() -- can't do much if this fails | |||
| goto err | |||
| end | |||
|
|
|||
| -- if timeout (default is 5s) we will close the connection | |||
| local ok, err = self:_meta_call(c, meta_cap, node_id) | |||
There was a problem hiding this comment.
Suggested change
| local ok, err = self:_meta_call(c, meta_cap, node_id) | |
| ok, err = self:_meta_call(c, meta_cap, node_id) |
| @@ -587,7 +587,7 @@ function _M:connect(premature, node_id, host, path, cert, key) | |||
|
|
|||
| local ok, err = c:connect(uri, opts) | |||
| if not ok then | |||
| ngx_log(ngx_ERR, _log_prefix, "unable to connect to peer: ", err) | |||
| err = "unable to connect to peer: " .. (err or "unknown error") | |||
| local worker_events = assert(kong.worker_events) | ||
|
|
||
| -- notify this worker | ||
| local ok, err = worker_events.post_local("clustering:jsonrpc", "connection_lost") |
There was a problem hiding this comment.
This may cause duplicated event when connection disconnected, what's your opinion? how do we distinguish them?
There was a problem hiding this comment.
I see, it is dp side event.
chronolaw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Emit an event when the connection is lost
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Precondition for KAG-6178