Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clustering/rpc): do not log disconnected node #14255

Merged
merged 1 commit into from
Feb 12, 2025
Merged

fix(clustering/rpc): do not log disconnected node #14255

merged 1 commit into from
Feb 12, 2025

Conversation

chronolaw
Copy link
Contributor

Summary

KAG-6372

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/clustering cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Feb 11, 2025
Oyami-Srk
Oyami-Srk approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@Oyami-Srk Oyami-Srk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to avoid error log flood. We should implement DP status awareness later.
E.g.: Remove from node list when DP got disconnected and add back when DP is reconnected.

@ADD-SP ADD-SP merged commit 706a32e into master Feb 12, 2025
36 checks passed
@ADD-SP ADD-SP deleted the fix/check_node_not_exists branch February 12, 2025 01:57
@ADD-SP ADD-SP added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Feb 12, 2025
@chronolaw chronolaw removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oyami-Srk Oyami-Srk Oyami-Srk approved these changes

@ADD-SP ADD-SP ADD-SP approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering size/XS skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chronolaw @Oyami-Srk @ADD-SP