perf(tools/string): a way faster strip function #14253
Merged
+14
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
### Summary In #13168 I made this already faster, but this time I managed to make it a way faster. Signed-off-by: Aapo Talvensaari <[email protected]>
|
Do we have some comparison for this? |
@chronolaw I updated the description. |
brentos
approved these changes
Feb 12, 2025
locao
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #13168 I made this already faster, but this time I managed to make it a way faster, main reason being:
Leading to potentially better JIT compilation results as well.
The code in my opinion is also easier to read and understand.
I get
3492 msreduced to (with this PR)149 msexecution time in microbenchmark.KAG-6354
Checklist
The Pull Request has testsA changelog file has been created underchangelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdThere is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE