Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clustering/rpc): add random for timer‘s name #14241

Merged
merged 2 commits into from
Feb 5, 2025
Merged

fix(clustering/rpc): add random for timer‘s name #14241

merged 2 commits into from
Feb 5, 2025

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Feb 5, 2025 •
edited
Loading

Summary

KAG-6336

Currently it is a temporary solution, we may work on it later.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/clustering cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Feb 5, 2025
@chronolaw chronolaw changed the title fix(clustering/rpc): negative id for notification timer‘s name fix(clustering/rpc): negative integer id for notification timer‘s name Feb 5, 2025
@chronolaw chronolaw marked this pull request as ready for review February 5, 2025 06:49
@chronolaw chronolaw changed the title fix(clustering/rpc): negative integer id for notification timer‘s name fix(clustering/rpc): add random for timer‘s name Feb 5, 2025
@chronolaw chronolaw requested a review from ADD-SP February 5, 2025 07:14
@chronolaw chronolaw mentioned this pull request Feb 5, 2025
Merged
3 tasks
@ADD-SP ADD-SP merged commit 6617d58 into master Feb 5, 2025
30 checks passed
@ADD-SP ADD-SP deleted the fix/random_id_for_notification branch February 5, 2025 09:08
@ADD-SP ADD-SP added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Feb 5, 2025
@chronolaw chronolaw removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bungle bungle bungle left review comments

@Oyami-Srk Oyami-Srk Oyami-Srk approved these changes

@ADD-SP ADD-SP ADD-SP approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering size/XS skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chronolaw @bungle @Oyami-Srk @ADD-SP