fix(llm): mark model.options.upstream_path as deprecated #14178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
schema-change-noteworthy
cherry-pick kong-ee
fffonion
force-pushed
the
deprecate-upstream-path
branch
from
24faa26 to
7b28ee2
Compare
oowl
approved these changes
Feb 5, 2025
ADD-SP
approved these changes
Feb 5, 2025
ADD-SP
added
incomplete-cherry-pick
|
Could you also link the cherry-pick PR? |
ADD-SP
reviewed
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
model.options.upstream_path caused some confusion in some drivers (namely openai and huggingface) a static prefix is always attached while others are not.
it’s also causing conflicts with upstream_url
Users would be able to move to use upstream_url to archieve same functionality.
may need to add a test
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
AG-201