Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): install lua-messagepack 0.5.2 by rock directly #14061

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

tzssangglass
Copy link
Member

@tzssangglass tzssangglass commented Dec 27, 2024

since lua-messagepack 0.5.2 has been archived, we can only install it directly via rock.

Fix: FTI-6417

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

since lua-messagepack 0.5.2 has been archived, we can only install it directly via rock.

Fix: [FTI-6417](https://konghq.atlassian.net/browse/FTI-6417)
Signed-off-by: tzssangglass <[email protected]>
@github-actions github-actions bot added build/bazel core/wasm Everything relevant to [proxy-]wasm labels Dec 27, 2024
@ms2008 ms2008 requested a review from Water-Melon January 2, 2025 02:25
Signed-off-by: tzssangglass <[email protected]>
@tzssangglass tzssangglass requested a review from windmgc January 6, 2025 03:09
@Water-Melon Water-Melon requested a review from ADD-SP January 9, 2025 10:19
@windmgc windmgc removed the core/wasm Everything relevant to [proxy-]wasm label Jan 10, 2025
@windmgc windmgc merged commit 3701fd4 into release/3.4.x Jan 10, 2025
25 checks passed
@windmgc windmgc deleted the lua-messagepack branch January 10, 2025 02:44
tzssangglass added a commit to Kong/lua-kong-nginx-module that referenced this pull request Jan 10, 2025
…tion step

removed the logic for modifying the lua-messagepack version in the .rockspec file from the CI workflow.

releated to:Kong/kong#14061

Signed-off-by: tzssangglass <[email protected]>
windmgc pushed a commit to Kong/lua-kong-nginx-module that referenced this pull request Jan 14, 2025
…tion step (#102)

removed the logic for modifying the lua-messagepack version in the .rockspec file from the CI workflow.

releated to:Kong/kong#14061

Signed-off-by: tzssangglass <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants