Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clustering): rebuild router if routes or services changed #13870

Closed
wants to merge 5 commits into from

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Nov 14, 2024

Summary

Refactor of #13860, should be tested by #13869.
KAG-5831
KAG-5560
KAG-5551

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/clustering cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Nov 14, 2024
@chronolaw chronolaw marked this pull request as ready for review November 14, 2024 08:09
--
-- Full sync could rebuild route, plugins and balancer route, so their
-- hashes are nil.
local reconfigure_data = { kong.default_workspace, nil, nil, nil, }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to caculate these hash values to avoid unnecessary rebuilding of routes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to generate a random to simulate hash.

@chronolaw chronolaw changed the title refactor(clustering): clean the logic of do_sync() fix(clustering): rebuild router if routes or services changed Nov 15, 2024
@chronolaw chronolaw requested a review from chobits November 15, 2024 01:56
@chronolaw chronolaw marked this pull request as draft November 15, 2024 02:12
@chronolaw chronolaw closed this Nov 15, 2024
@chronolaw chronolaw deleted the refactor/clean_rpc_wipe_logic branch January 9, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering size/M skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants