fix(clustering/rpc): cascade deleting for incremental sync #13836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
cherry-pick kong-ee
chronolaw
changed the title
| @@ -161,8 +166,38 @@ function _M:register_dao_hooks() | |||
|
|
|||
| ngx_log(ngx_DEBUG, "[kong.sync.v2] new delta due to deleting ", name) | |||
|
|
|||
| -- set lmdb value to ngx_null then return row | |||
| return self:entity_delta_writer(entity, name, options, ws_id, true) | |||
There was a problem hiding this comment.
It seems that we lost this logic in the new patch? Is it intended?
There was a problem hiding this comment.
Yes, entity_delta_writer() only process one entity, but in deletion we may have many entities, but the basic logic is same, please compare to entity_delta_writer().
StarlightIbuki
approved these changes
Nov 6, 2024
chobits
approved these changes
Nov 6, 2024
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13836-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13836-to-master-to-upstream
git checkout -b cherry-pick-13836-to-master-to-upstream
ancref=$(git merge-base d4ab528fa2414d996861a43e58406c02b4978157 c77a50c7a859055b0c01251285acf6513abc2dda)
git cherry-pick -x $ancref..c77a50c7a859055b0c01251285acf6513abc2dda |
github-actions
bot
added
the
incomplete-cherry-pick
kikito
removed
the
incomplete-cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
KAG-5755
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]