Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clustering): adjust control plane log level when client closes the connection #13714

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

bungle
Copy link
Member

@bungle bungle commented Sep 26, 2024

Summary

Currently controlplane logs at ERROR level when dataplane closes the connection. This commit lowers the log level to DEBUG in this common case.

KAG-5476

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

@github-actions github-actions bot added core/clustering cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Sep 26, 2024
@bungle bungle force-pushed the chore/clustering-client-close-log-level branch 3 times, most recently from 6a40807 to 1ef9b24 Compare September 26, 2024 16:33
Copy link
Member

@samugi samugi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I would maybe try to reduce the scope of the change, if possible, to only affect the log in the branch where we expect the connection closed message to appear (probably the perr one, I assume)

@bungle
Copy link
Member Author

bungle commented Sep 27, 2024

LGTM I would maybe try to reduce the scope of the change, if possible, to only affect the log in the branch where we expect the connection closed message to appear (probably the perr one, I assume)

Thanks. Let me try it.

…the connection

### Summary

Currently controlplane logs at ERROR level when dataplane closes the connection.
This commit lowers the log level to `DEBUG` in this common case.

Signed-off-by: Aapo Talvensaari <[email protected]>
@bungle bungle force-pushed the chore/clustering-client-close-log-level branch from 1ef9b24 to 38faeff Compare September 27, 2024 09:44
@bungle
Copy link
Member Author

bungle commented Sep 27, 2024

LGTM I would maybe try to reduce the scope of the change, if possible, to only affect the log in the branch where we expect the connection closed message to appear (probably the perr one, I assume)

Ok, reduced to perr case only.

@bungle bungle merged commit d1fc73b into master Sep 27, 2024
26 checks passed
@bungle bungle deleted the chore/clustering-client-close-log-level branch September 27, 2024 13:27
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

curiositycasualty pushed a commit that referenced this pull request Oct 15, 2024
…the connection (#13714)

### Summary

Currently controlplane logs at ERROR level when dataplane closes the connection.
This commit lowers the log level to `DEBUG` in this common case.

Signed-off-by: Aapo Talvensaari <[email protected]>
(cherry picked from commit d1fc73b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering size/S skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants