-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(response-ratelimiting): fix missing usage headers for upstream #13696
fix(response-ratelimiting): fix missing usage headers for upstream #13696
Conversation
@t-yuki Thanks for your contribution! Would you mind adding a regression test on this issue? I think we have missed this test for a long time. And also a changelog entry. |
Since this is a new issue introduced in 3.8 and should be a small fix, I added this to the 3.9 milestone. Internal ticket: KAG-5447 |
be001e0
to
d785d18
Compare
d785d18
to
7b344bb
Compare
@t-yuki Could you fix failure tests? |
OK, I'll try to continue within a week. |
7b344bb
to
9d4e821
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog/unreleased/kong/fix-response-ratelimiting-upstream-headers.yml
Outdated
Show resolved
Hide resolved
changelog/unreleased/kong/fix-response-ratelimiting-upstream-headers.yml
Outdated
Show resolved
Hide resolved
Approved to run CIs against https://github.com/Kong/kong/pull/13696/files/b98da5efa4c8a70cb05725b9ea09c5ff680c8170. |
CI is not started 🤔, no idea about the reason yet. |
…eaders.yml Co-authored-by: Guilherme Salazar <[email protected]>
…eaders.yml Co-authored-by: BrianChen <[email protected]>
b98da5e
to
3b90bfd
Compare
@t-yuki Thanks for your contribution! |
Summary
response-ratelimiting
plugin should send usage headers to upstream server.But in Kong 3.8, there are no usage headers such as
X-RateLimit-Remaining-Videos: 10
for upstream requests.In this change, it coming back usage headers for upstream.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #13682