tests(workflows): continue execution of subscribers #12291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samugi
force-pushed
the
tests/busted-subscriber-helper
branch
3 times, most recently
from
b237c65 to
cb3bf65
Compare
samugi
changed the title
add the correct return value to the busted helper handler so that other subscribers are also called, see: https://github.com/Olivine-Labs/mediat or_lua/blob/ae97959308b462d84d0255f511c8e14cdf06667f/src/mediator.lua#L1 03C24-L103C32
hanshuebner
force-pushed
the
tests/busted-subscriber-helper
branch
from
cb3bf65 to
21425ea
Compare
|
closing because we are getting rid of this file with the scheduler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add the correct return value to the busted helper so that other subscribers are also called, see: https://github.com/Olivine-Labs/mediator_lua/blob/ae97959308b462d84d0255f511c8e14cdf06667f/src/mediator.lua#L103C24-L103C32 also related to: #12286
This is currently not causing any visible issues, but it might block execution of any other existing subscribers for those events.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-3481