fix(plugins/request-transformer): remove lower-cased name when setting header value #12289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chronolaw
added
the
cherry-pick kong-ee
chronolaw
changed the title
ADD-SP
requested changes
Jan 4, 2024
changelog/unreleased/kong/fix-request-transformer-rename-header.yml
Outdated
Show resolved
Hide resolved
chronolaw
added
the
pr/discussion
chronolaw
changed the title
|
We will revert #12244 then fix this flakiness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As OpenResty's doc says (https://github.com/openresty/lua-nginx-module?tab=readme-ov-file#ngxreqget_headers), the result of
ngx.req.get_headers()always has lower-case header name,So if we set a
X-Nameheader, it will not overwrite the existing headerx-name.This PR also fixed some flaky test cases(spec/03-plugins/36-request-transformer).
KAG-3462
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]