Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport 3.5.x] urgent to unblock pr merge #12211

Closed
wants to merge 2 commits into from
Closed

[backport 3.5.x] urgent to unblock pr merge #12211

wants to merge 2 commits into from

Conversation

outsinre
Copy link
Contributor

Urgent backport #12186 and #12210

dependabot bot and others added 2 commits December 14, 2023 15:40
@dependabot @outsinre
chore(deps): bump actions/labeler from 4 to 5 (#12186)
2ccddc3 
Bumps [actions/labeler](https://github.com/actions/labeler) from 4 to 5.
- [Release notes](https://github.com/actions/labeler/releases)
- [Commits](actions/labeler@v4...v5)

---
updated-dependencies:
- dependency-name: actions/labeler
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dndx @outsinre
chore(labeler): upgrade to version 5 syntax and use the official acti…
1c03504 
…on workflow file from `actions/labeler` (#12210)

KAG-3349
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Dec 14, 2023
@outsinre outsinre requested a review from dndx December 14, 2023 07:43
@bungle
Copy link
Member

bungle commented Dec 14, 2023 •
edited
Loading

@outsinre is this needed for 3.5.x or is the new syntax correct with older version of labeler as well? We haven't backported labeler bump to 3.5.x, so just checking if this is fine with old labeler too?

@outsinre
Copy link
Contributor Author

@outsinre is this needed for 3.5.x or is the new syntax correct with older version of labeler as well? We haven't backported labeler bump to 3.5.x, so just checking if this is fine with old labeler too?

Not sure if the bot will sometime later bump the version in 3.5.x branch. If not, we can skip it.

@outsinre
Copy link
Contributor Author

@outsinre is this needed for 3.5.x or is the new syntax correct with older version of labeler as well? We haven't backported labeler bump to 3.5.x, so just checking if this is fine with old labeler too?

Double-checked with @AndyZhang0707 , the bot only bump actions on master branch. Let me close it.

@outsinre outsinre closed this Dec 14, 2023
@outsinre outsinre deleted the FTI-5640/urgent-to-unblock-pr-merge/35x branch January 8, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bungle bungle bungle approved these changes

@AndyZhang0707 AndyZhang0707 AndyZhang0707 approved these changes

@dndx dndx Awaiting requested review from dndx

Assignees

@outsinre outsinre

Labels
chore Not part of the core functionality of kong, but still needed size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@outsinre @bungle @AndyZhang0707 @dndx