-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport release/3.2.x] chore(patches): fix ldoc intermittent fail caused by LuaJIT #12143
Conversation
4480926
to
9f14932
Compare
@bungle The CI's build cache is hit and there is no build log to check in CI build log. But I verified it locally and hope I have not missed something. @flrgh do you know whether the build cache hit in this case is expected? I changed the patch format in the latest commit (9f14932) and expect the build will run from scratch. CI build log: |
@zhongweiy you have missed something:
This is how I test these:
Please use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment above.
(cherry picked from commit c7c44a2)
9f14932
to
dcc2ab2
Compare
updated. I should come up some patch to make this process easier. |
@zhongweiy and also a test that does not allow non-cleanly applying patches, or upgrading openresty and then make patches not apply correctly, should also be blocked. |
Backport c7c44a2 from #11983.
Fix #KAG-1761