fix(core): always pass ngx.ctx to log_init_worker_errors (#13731)

Signed-off-by: Aapo Talvensaari <[email protected]>
Kong · Nov 12, 2024 · fd7ea93 · fd7ea93 · github-actions · Nov 12, 2024
1 parent 7047692
commit fd7ea93
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/changelog/unreleased/kong/fix-core-pass-ctx-to-log-init-worker-errors.yml b/changelog/unreleased/kong/fix-core-pass-ctx-to-log-init-worker-errors.yml
@@ -0,0 +1,4 @@
+message: |
+   Fix to always pass `ngx.ctx` to `log_init_worker_errors` as otherwise it may runtime crash.
+type: bugfix
+scope: Core
diff --git a/kong/init.lua b/kong/init.lua
@@ -1962,10 +1962,12 @@ end
 Kong.status_header_filter = Kong.admin_header_filter
 
 
-function Kong.serve_cluster_listener(options)
-  log_init_worker_errors()
+function Kong.serve_cluster_listener()
+  local ctx = ngx.ctx
+
+  log_init_worker_errors(ctx)
 
-  ngx.ctx.KONG_PHASE = PHASES.cluster_listener
+  ctx.KONG_PHASE = PHASES.cluster_listener
 
   return kong.clustering:handle_cp_websocket()
 end
@@ -1976,10 +1978,12 @@ function Kong.stream_api()
 end
 
 
-function Kong.serve_cluster_rpc_listener(options)
-  log_init_worker_errors()
+function Kong.serve_cluster_rpc_listener()
+  local ctx = ngx.ctx
+
+  log_init_worker_errors(ctx)
 
-  ngx.ctx.KONG_PHASE = PHASES.cluster_listener
+  ctx.KONG_PHASE = PHASES.cluster_listener
 
   return kong.rpc:handle_websocket()
 end