address pr review feedback (squash this)

Kong · Dec 21, 2023 · fc33737 · fc33737
1 parent ec80b2a
commit fc33737
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/kong/pdk/tracing.lua b/kong/pdk/tracing.lua
@@ -559,7 +559,7 @@ local function new_tracer(name, options)
   --
   -- Else, apply the probability-based should_sample decision.
   --
-  -- @function kong.tracing:set_should_sample
+  -- @function kong.tracing:get_sampling_decision
   -- @tparam bool parent_should_sample value of the parent span sampled flag
   -- extracted from the incoming tracing headers
   -- @tparam number sampling_rate the sampling rate to apply for the

diff --git a/spec/03-plugins/37-opentelemetry/04-exporter_spec.lua b/spec/03-plugins/37-opentelemetry/04-exporter_spec.lua
@@ -131,7 +131,6 @@ for _, strategy in helpers.each_strategy() do
           })
           assert.res_status(200, r)
 
-          -- close client connection
           cli:close()
 
           local lines
@@ -209,7 +208,6 @@ for _, strategy in helpers.each_strategy() do
           })
           assert.res_status(200, r)
 
-          -- close client connection
           cli:close()
 
           ngx.sleep(2)
@@ -230,7 +228,6 @@ for _, strategy in helpers.each_strategy() do
             })
             assert.res_status(200, r)
 
-            -- close client connection
             cli:close()
 
             local lines
@@ -289,7 +286,6 @@ for _, strategy in helpers.each_strategy() do
           })
           assert.res_status(200, r)
 
-          -- close client connection
           cli:close()
 
           local lines, err = mock()
@@ -340,7 +336,6 @@ for _, strategy in helpers.each_strategy() do
           })
           assert.res_status(200, r)
 
-          -- close client connection
           cli:close()
 
           local lines
@@ -438,7 +433,6 @@ for _, strategy in helpers.each_strategy() do
         })
         assert.res_status(200, r)
 
-        -- close client connection
         cli:close()
 
         helpers.wait_until(function()
@@ -509,7 +503,6 @@ for _, strategy in helpers.each_strategy() do
           })
           assert.res_status(200, r)
 
-          -- close client connection
           cli:close()
 
           local lines
@@ -591,7 +584,6 @@ for _, strategy in helpers.each_strategy() do
           })
           assert.res_status(200, r)
 
-          -- close client connection
           cli:close()
 
           local lines