forked from jl777/SuperNET
-
Notifications
You must be signed in to change notification settings - Fork 110
feat(LR): execute_routed_trade RPC implementation #2546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dimxy
wants to merge
17
commits into
dev
Choose a base branch
from
lr-swap-wip-3
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,908
−740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dev: chore(rust 1.89): make CI clippy/fmt pass (wasm32, all-targets) (#2581) fix(utxo): deserialize sapling root for PIVX block headers (#2572) improvement(dep-stack): security bumps (#2562) fix(utxo): correct block header deserialization for AuxPow and KAWPOW coins (#2563) # Conflicts: # mm2src/mm2_main/tests/docker_tests/eth_docker_tests.rs
…p and do it only in the test itself
* dev: fix build script failing to find .git/HEAD (#2601) refactor(EVM): rename fn, fix timeouts, add activation req validation (#2543) improvement(`static mut`s): `static mut` removal (#2590) fix(orders): set subscription on kickstart and skip GC of own pubkeys (#2597) fix(ordermatch): ignore loop-back; clear on null root; reject stale keep-alives (#2580) fix(clippy): fix clippy warnings for #2565 (#2589) fix(Trezor): fix utxo and eth calls due to firmware changes (#2565) # Conflicts: # mm2src/mm2_main/src/lp_swap/taker_swap.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[]
feature: swap
priority: medium
Moderately important tasks that should be completed but are not urgent.
status: pending review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next development step for liquidity routing (LR) feature (WIP).
Adds
execute_routed_tradeRPC and state machine implementation to execute taker swaps with LR-steps before and after the atomic swap.As input params,
execute_routed_tradeRPC accepts results of thefind_best_quoteRPC.Here is a description of
find_best_quoteinput params, response and usage:#2545 (comment)
Some additional info for
the execute_routed_tradeRPC from the source code:komodo-defi-framework/mm2src/mm2_main/src/rpc/lp_commands/lr_swap_api.rs
Line 138 in 4abee64
TODO: add spec for
execute_routed_tradeRPC params and response