Add loop_factory parameter for persistent event loops#363
Open
jrobbins-LiveData wants to merge 6 commits intoKludex:mainfrom
Open
Add loop_factory parameter for persistent event loops#363jrobbins-LiveData wants to merge 6 commits intoKludex:mainfrom
jrobbins-LiveData wants to merge 6 commits intoKludex:mainfrom
Conversation
This is a local settings file that shouldn't be tracked. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove mangum-ld package rename and CodeArtifact config that were used for testing. Restore original package name and version. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The event loop only needs to be set as current once when created, not on every request invocation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Owner
|
|
Author
|
AFAICT, passing loop_factory to |
|
Hi @jrobbins-LiveData. Is the issue still persisting after #375? |
Author
|
@tampueroc, the revert to previous loop behavior in #376 fixed the issue that #375 had caused us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
loop_factoryparameter toMangumthat enables persistent event loops across Lambda invocations. This is similar to uvicorn'sloopparameter.Use cases:
uvloopfor better performanceChanges
loop_factory: LoopFactory | Noneparameter toMangum.__init__LoopFactorytype alias tomangum.typesfor external usedocs/adapter.mdUsage
Or with uvloop:
Notes
The loop is not closed automatically by Mangum - in Lambda, it persists until the execution environment is recycled
For testing, callers are responsible for closing the loop explicitly
Related
Addresses use case discussed in #361