Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM] align file categories with figma designs #2420

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

0xMakka
Copy link
Collaborator

@0xMakka 0xMakka commented Jan 29, 2025

Description

After a discussion with @jabby09 - the file categories need to be aligned with the current figma designs

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 2:54pm
klimadao-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 2:54pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
carbon ⬜️ Ignored (Inspect) Jan 29, 2025 2:54pm

@0xAurelius
Copy link
Contributor

So my concern with lumping Methodology and PDD this way is that methodology documents are typically (in the existing external registry projects) associated with the Methodology entity itself in the CMS as an external file URL, rather than the individual project as a hosted file

we can reupload the methodology document on the individual project as well, but I though it would be "cleaner" to have this be a separate category so that way if a given project uses a standard methodology, whose document is linked from the Methodology section of the project page, the user isn't confused why there is a Documents section called "PDD and Methodology" but then it doesn't contain a Methodology document - and similarly if there is a unique project-specific methodology doc, then it gets the Methodology category shows up under Documents

I'm also concerned that PDD is jargon and some users may not know what the acronym stands for...

My apologies for not communicating better about these minor issues, let's discuss this

@0xAurelius 0xAurelius merged commit 667b9e3 into staging Jan 29, 2025
6 checks passed
@0xAurelius 0xAurelius deleted the makka/align-file-categories-with-designs branch January 29, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants