-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor /projects and /projects/:id routes and change /user/:walletorHandle routes #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jabby09
approved these changes
Jan 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is intented to solve the discrepency on the way prices are computed in the API. It intraduces a massive refactor of the /projects and /projects:id routes so both of them use the same algorithm to compute a project instance.
This is a proposal. If we use this PR I think we will need to QA the whole application.
Here is what is inside:
/projects
and/projects/:id
/user/:walletOrHandle
routesbuildProjectEntry
method that composes a Project instance based on CMS project content, polygon-digital-carbon subgraph data,Depending on what we decide for the release process, I will create another PR with only the API changes
Related Ticket
Closes #2020
Closes #1035
Notes For QA
Specific pages, components or journeys that might be affected:
Other notes: