Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor /projects and /projects/:id routes and change /user/:walletorHandle routes #2049

Merged
merged 39 commits into from
Jan 9, 2024

Conversation

biwano
Copy link
Collaborator

@biwano biwano commented Dec 20, 2023

Description

This PR is intented to solve the discrepency on the way prices are computed in the API. It intraduces a massive refactor of the /projects and /projects:id routes so both of them use the same algorithm to compute a project instance.
This is a proposal. If we use this PR I think we will need to QA the whole application.
Here is what is inside:

  • Introduces a minSupply argument to the /projects and /projects/:id /user/:walletOrHandle routes
  • Listings and credits are filtered out AT QUERY LEVEL if the supply available in less than the minSupply argument.
  • Introduces a buildProjectEntry method that composes a Project instance based on CMS project content, polygon-digital-carbon subgraph data,

Depending on what we decide for the release process, I will create another PR with only the API changes

Related Ticket

Closes #2020
Closes #1035

Notes For QA

Specific pages, components or journeys that might be affected:

  • The whole Application

Other notes:

  • This is a work in progress, please wait that there is an engineering consensus about the PR before QAing.

@biwano biwano deployed to Preview – carbonmark-api December 20, 2023 14:48 — with GitHub Actions Active
Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 8:21am
carbonmark ✅ Ready (Inspect) Visit Preview Jan 9, 2024 8:21am
carbonmark-api ✅ Ready (Inspect) Visit Preview Jan 9, 2024 8:21am
demo-integration ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 8:21am
klimadao-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 8:21am

@biwano biwano deployed to Preview – carbonmark-api December 21, 2023 09:57 — with GitHub Actions Active
@biwano biwano dismissed Atmosfearful’s stale review January 9, 2024 07:35

Changes made in package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
6 participants