Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KLIMADAO/Klimadao] Polygon-digital-carbon for retirement data #2048

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

psparacino
Copy link
Collaborator

@psparacino psparacino commented Dec 20, 2023

Description

Removes bridged-carbon from fetching retirement data for /retirements and /retirements/[index].

Eventually /retirements will be moved to an endpoint. This is an interim solution for ICR; the ICR retirement data is only available on digital-carbon.

NOTES:

  1. This PR uses several subgraphs deployed to testing (i.e. personal) accounts. This PR should not be merged until they are deployed under the main klimadao (or maybe now new one for carbonmark?) graph account.
  2. I'm using a placeholder ICR logo for now:
Screen Shot 2023-12-19 at 8 47 01 PM

Open question as to what image should be used for the ICR logo

  1. Anything in site/ can be ignored

Related Ticket

Closes #1938
Also related to #2047

Notes For QA

Specific pages, components or journeys that might be affected:

  • /retirements and /retirements/[index]

Relevant preview URLs:

  • Below

Other notes:

Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbonmark ✅ Ready (Inspect) Visit Preview Jan 10, 2024 6:34pm
carbonmark-api ✅ Ready (Inspect) Visit Preview Jan 10, 2024 6:34pm
demo-integration ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 6:34pm
klimadao-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 6:34pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
carbon ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 6:34pm

@psparacino psparacino changed the title app: polygon-carbon retirement data [APP] Polygon-digital-carbon for retirement data Dec 20, 2023
@psparacino psparacino force-pushed the APP_tufnel/update-subgraph-for-retirement-data branch from 3b2ac9d to e020aa4 Compare December 20, 2023 02:37
@psparacino psparacino deployed to Preview – carbonmark-api December 20, 2023 02:37 — with GitHub Actions Active
@psparacino psparacino force-pushed the APP_tufnel/update-subgraph-for-retirement-data branch from e020aa4 to 4e25e82 Compare December 20, 2023 02:52
@psparacino psparacino deployed to Preview – carbonmark-api December 20, 2023 02:54 — with GitHub Actions Active
@psparacino psparacino force-pushed the APP_tufnel/update-subgraph-for-retirement-data branch from 4e25e82 to 8ee0fb3 Compare December 20, 2023 03:45
@psparacino psparacino deployed to Preview – carbonmark-api December 20, 2023 03:45 — with GitHub Actions Active
@psparacino psparacino changed the title [APP] Polygon-digital-carbon for retirement data [KLIMADAO/Klimadao] Polygon-digital-carbon for retirement data Dec 20, 2023
@psparacino psparacino deployed to Preview – carbonmark-api December 20, 2023 15:15 — with GitHub Actions Active
@0xemc
Copy link
Collaborator

0xemc commented Jan 10, 2024

@psparacino where are we at with this?

@psparacino
Copy link
Collaborator Author

psparacino commented Jan 10, 2024

@0xemc The staging subgraph is now fully synced so it should be an immediate deploy to main once the PR is merged in the subgraph repo. All the prod subgraphs have been updated in this pr so once the main deployment is ready we can just hit merge.

@0xemc
Copy link
Collaborator

0xemc commented Jan 10, 2024

@0xemc The staging subgraph is now fully synced so it should be an immediate deploy to main once the PR is merged in the subgraph repo. All the prod subgraphs have been updated in this pr so once the main deployment is ready we can just hit merge.

Cool thanks, can you link the dependent subgraph repo PR here please?

@psparacino
Copy link
Collaborator Author

@0xemc Repo: https://github.com/KlimaDAO/klima-subgraph

Once this PR is merged as far as I understand the main deployment should be live almost immediately

lib/constants/index.ts Outdated Show resolved Hide resolved
@0xemc
Copy link
Collaborator

0xemc commented Jan 10, 2024

@psparacino it's still not clear to me why it was necessary to wait for the subgraph PR since the preview build was passing with the updated subgraph url in lib/constants.ts?

This suggests to me we are not capturing or covering some possible source of bugs in our build pipeline. Can you TLDR this for me?

@psparacino
Copy link
Collaborator Author

psparacino commented Jan 10, 2024

@0xemc The essential difference is that this PR requires the hash attribute on the retire entity on the digital-carbon subgraph (which the current subgraph deployed to klimadao/polygon-digital-carbon does not have, but which the that is syncing does).

Everything builds but the page will 404 if used with the current main subgraph. Just tried both locally with old and new to confirm.

This is likely because there is no api call to fail as the query happens from the frontend. I created a overall debt issue to and logged the issue to move that query to an endpoint here: #2093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[subgraph] Migrate to polygon-digital-carbon
5 participants