-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KLIMADAO/Klimadao] Polygon-digital-carbon for retirement data #2048
[KLIMADAO/Klimadao] Polygon-digital-carbon for retirement data #2048
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
3b2ac9d
to
e020aa4
Compare
e020aa4
to
4e25e82
Compare
4e25e82
to
8ee0fb3
Compare
carbonmark/lib/retirementDataQueries/getProjectInfoViaPolygonDigitalCarbon.ts
Show resolved
Hide resolved
@psparacino where are we at with this? |
@0xemc The staging subgraph is now fully synced so it should be an immediate deploy to main once the PR is merged in the subgraph repo. All the prod subgraphs have been updated in this pr so once the main deployment is ready we can just hit merge. |
2d1b392
to
93f9ead
Compare
Cool thanks, can you link the dependent subgraph repo PR here please? |
@0xemc Repo: https://github.com/KlimaDAO/klima-subgraph Once this PR is merged as far as I understand the main deployment should be live almost immediately |
93f9ead
to
89e937b
Compare
@psparacino it's still not clear to me why it was necessary to wait for the subgraph PR since the preview build was passing with the updated subgraph url in This suggests to me we are not capturing or covering some possible source of bugs in our build pipeline. Can you TLDR this for me? |
@0xemc The essential difference is that this PR requires the hash attribute on the retire entity on the digital-carbon subgraph (which the current subgraph deployed to Everything builds but the page will 404 if used with the current main subgraph. Just tried both locally with old and new to confirm. This is likely because there is no api call to fail as the query happens from the frontend. I created a overall debt issue to and logged the issue to move that query to an endpoint here: #2093 |
89e937b
to
2622f3f
Compare
2622f3f
to
ad16bc0
Compare
Description
Removes
bridged-carbon
from fetching retirement data for/retirements
and/retirements/[index]
.Eventually
/retirements
will be moved to an endpoint. This is an interim solution for ICR; the ICR retirement data is only available ondigital-carbon
.NOTES:
Open question as to what image should be used for the ICR logo
site/
can be ignoredRelated Ticket
Closes #1938
Also related to #2047
Notes For QA
Specific pages, components or journeys that might be affected:
Relevant preview URLs:
Other notes: