Emc/fix/1944-profile-portfolio-issues

[0xemc]

Description

• Replace a === null check that was failing because of undefined
• Pass the User object directly from getStaticProps rather than through SWRConfig

Resolves the following from #1944:

• When I access another users public profile (for example https://www.carbonmark.com/users/offsetra) the initial screen view flashes the Listings - No active listings page before rendering properly

JABBY CONFIRMS FIXED

• Recent portfolio page content changes that were merged as part of [portfolio] Default page content changes #1063 not longer seem to be there anymore. Currently if you do not have a profile, the Portfolio page is completely blank.

JABBY CONFIRMS FIXED

• A new login with no Profile created should still show the temp avatar and wallet and stats / activity components. The figma design for a seller that has logged in but not yet set up their profile is here; assuming the Marketplace navigation item is still active; i.e. start from the marketplace, click login, go through the login modal, end up on this page.

JABBY CONFIRMS FIXED

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
carbonmark	✅ Ready (Inspect)	Visit Preview		Dec 1, 2023 6:39pm
carbonmark-api	✅ Ready (Inspect)	Visit Preview		Dec 1, 2023 6:39pm
demo-integration	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 1, 2023 6:39pm
klimadao-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 1, 2023 6:39pm
klimadao-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 1, 2023 6:39pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
carbon	⬜️ Ignored (Inspect)	Visit Preview		Dec 1, 2023 6:39pm

[jabby09]

@0xemc which two issues does this PR fix?

[0xemc]

@0xemc which two issues does this PR fix?

@jabby09 I'll be adding them in the description as I go. If you'd like to confirm on the preview link that'd be good or wait until they're all finshed

[0xemc]

@jabby if you're ok with these fixes we can close this PR and tackle the others after.

CC: @Atmosfearful

[jabby09]

if you're ok with these fixes we can close this PR and tackle the others after.

@0xemc checking now

[Atmosfearful]

I tested mainnet and testnet logins
viewing my own page and another users page for both
everything works!

Only minor issue is when viewing your own page and logging in, there is a flash if missing listings while the React component is swapped from the public view to the SellerConnected view. It's a minor issue but I'm sure we can find a solution by passing props down.

Merging and releasing. Thanks for staying up late for this one @0xemc