-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare change in fillet api #5168
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
08fbdfb
to
b30ae5c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5168 +/- ##
==========================================
- Coverage 86.05% 86.05% -0.01%
==========================================
Files 90 90
Lines 32660 32656 -4
==========================================
- Hits 28106 28102 -4
Misses 4554 4554
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this actually do? It allows the face ID to get updated later?
yeah later on im nuking the face_id, becasue it uses the cmd_id, which is inline with all the other commands behavior, this one had a weird behavior so im fixing it sorry i meant to link the original issue KittyCAD/modeling-api#566 |
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
e1cb75d
to
fe304b5
Compare
e1d0d56
to
fe304b5
Compare
No description provided.