Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare change in fillet api #5168

Merged
merged 4 commits into from
Jan 28, 2025
Merged

prepare change in fillet api #5168

merged 4 commits into from
Jan 28, 2025

Conversation

jessfraz
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jan 28, 2025 9:48pm

Copy link

qa-wolf bot commented Jan 28, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.05%. Comparing base (8ca8c49) to head (fe304b5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5168      +/-   ##
==========================================
- Coverage   86.05%   86.05%   -0.01%     
==========================================
  Files          90       90              
  Lines       32660    32656       -4     
==========================================
- Hits        28106    28102       -4     
  Misses       4554     4554              
Flag Coverage Δ
wasm-lib 86.05% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jtran jtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this actually do? It allows the face ID to get updated later?

@jessfraz
Copy link
Contributor Author

yeah later on im nuking the face_id, becasue it uses the cmd_id, which is inline with all the other commands behavior, this one had a weird behavior so im fixing it sorry i meant to link the original issue KittyCAD/modeling-api#566

Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
@jessfraz jessfraz force-pushed the prepare-change-in-fillet-api branch from e1cb75d to fe304b5 Compare January 28, 2025 21:20
@jessfraz jessfraz force-pushed the prepare-change-in-fillet-api branch from e1d0d56 to fe304b5 Compare January 28, 2025 21:54
@jessfraz jessfraz disabled auto-merge January 28, 2025 21:54
@jessfraz jessfraz enabled auto-merge (squash) January 28, 2025 21:54
@jessfraz jessfraz merged commit 69fec37 into main Jan 28, 2025
63 checks passed
@jessfraz jessfraz deleted the prepare-change-in-fillet-api branch January 28, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants