Migrate Extrude AST mod from XState action to actor #5146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5146 +/- ##
=======================================
Coverage 85.94% 85.94%
=======================================
Files 90 90
Lines 32718 32718
=======================================
Hits 28121 28121
Misses 4597 4597
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lf94
approved these changes
Jan 27, 2025
franknoirot
force-pushed
the
franknoirot/adhoc/extrude-action-to-actor
branch
from
cdbc788 to
68efa18
Compare
|
Snapshots lying |
franknoirot
force-pushed
the
franknoirot/adhoc/extrude-action-to-actor
branch
from
5b6bcd8 to
68efa18
Compare
franknoirot
force-pushed
the
franknoirot/adhoc/extrude-action-to-actor
branch
from
4e2edf0 to
2f868ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of our drive to clean up incorrect usage of XState to eliminate race conditions in the app. Actions never await or are asynchronous, so the async callback within this action was never properly handled.
This change was also made as a part of #5045 but I've broken it out here in case this can get in sooner and @adamchalmers can benefit from it for his kwargs work.