-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adding unit test to test getNodeFromPath
failures
#5134
base: main
Are you sure you want to change the base?
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
getNodeFromPath
failures
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5134 +/- ##
=======================================
Coverage 86.14% 86.14%
=======================================
Files 89 89
Lines 32489 32489
=======================================
Hits 27987 27987
Misses 4502 4502
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
relates #4850
Issue
When Jess sketched the final
lineTo
withclose
which which was invoked insceneEntities.ts
the code appeared to fail when finding a node in the functiongetNodeFromPath
which produces a toast error.Implementation
There are tons of calls to
getNodeFromPath
which is the location that the errornot an object
comes from. Retracing her steps I could not manually reproduce this error by using the application.I followed the block of code in
sceneEntities.ts:787
which goes into the block of snapping logic to snap back to the original point and create alineTo
andclose
block.I implemented a set of unit tests to see if I can create this failure
I mimic the same code flow to call the code mods that need to call
getNodeFromPath
and in this example with the same exact code I was unable to reproduce that same error.