Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Shell dry-run validation with thickness arg #5118

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pierremtb
Copy link
Collaborator

@pierremtb pierremtb commented Jan 20, 2025

@nadr0 I was playing with this today. Moves the shell validation to the last argument (thickness) so we can run it on provided selections and thickness. Maybe this workflow could become the default one for the review stage of the command bar process. Or evolve into something else. But I figured this wasn't the only command that it could be useful for. Let me know if you have any thoughts

Copy link

qa-wolf bot commented Jan 20, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

1 similar comment
Copy link

qa-wolf bot commented Jan 20, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jan 22, 2025 4:25pm

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.14%. Comparing base (440704e) to head (bfb0bd6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5118   +/-   ##
=======================================
  Coverage   86.14%   86.14%           
=======================================
  Files          89       89           
  Lines       32489    32489           
=======================================
  Hits        27987    27987           
  Misses       4502     4502           
Flag Coverage Δ
wasm-lib 86.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nadr0
Copy link
Collaborator

nadr0 commented Jan 23, 2025

Yeah this is a good idea within the command bar. Since the user provides these values step by step, it makes sense to help them from shooting themselves in their foot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants