Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Point-and-Click Deletion for Fillets and Chamfers #5098

Merged
merged 79 commits into from
Feb 3, 2025

Conversation

max-mrgrsk
Copy link
Collaborator

@max-mrgrsk max-mrgrsk commented Jan 17, 2025

Description

This PR enables fillets and chamfers to be deleted through a point-and-click interface. Key updates include:

  • Deletion Support: Allows removing both piped and non-piped fillets and chamfers.
  • Testing: Includes thorough unit and Playwright tests for piped and non-piped scenarios.
  • Refactoring: Moves the deletion logic into the edgeTreatment code module for better organization.

Future Improvements

  • Multiple Selections: Extend deletion to handle multiple items simultaneously.
  • Partial Treatment Deletion: Fine tune cases where multiple tags are present in a single expression. If only one treatment is selected, only that treatment should be deleted rather than the entire expression.

Note: These additional use cases have been added to the Fillet UI project and will be addressed in a separate PR.

Closes: #5053

@max-mrgrsk max-mrgrsk linked an issue Jan 17, 2025 that may be closed by this pull request
Copy link

qa-wolf bot commented Jan 17, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@max-mrgrsk max-mrgrsk self-assigned this Jan 17, 2025
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 2, 2025 6:03pm

@max-mrgrsk max-mrgrsk added the ast Issues / features relevant to ast and parser. label Jan 17, 2025
@max-mrgrsk max-mrgrsk added this to the v1 Modeling App Launch milestone Jan 17, 2025
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.95%. Comparing base (f1a458f) to head (112a170).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5098   +/-   ##
=======================================
  Coverage   85.95%   85.95%           
=======================================
  Files          90       90           
  Lines       32912    32912           
=======================================
  Hits        28291    28291           
  Misses       4621     4621           
Flag Coverage Δ
wasm-lib 85.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pierremtb pierremtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! And I was able to test locally, both FT and GUI selection deletion worked well for me, it's really good to see 🥇

@pierremtb pierremtb merged commit 3e8ee3f into main Feb 3, 2025
31 checks passed
@pierremtb pierremtb deleted the max-click-delete-chamfers branch February 3, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ast Issues / features relevant to ast and parser.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Point-and-click deletion of fillets and chamfers
3 participants