-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Point-and-Click Deletion for Fillets and Chamfers #5098
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…AD/modeling-app into max-click-delete-chamfers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5098 +/- ##
=======================================
Coverage 85.95% 85.95%
=======================================
Files 90 90
Lines 32912 32912
=======================================
Hits 28291 28291
Misses 4621 4621
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…AD/modeling-app into max-click-delete-chamfers
…AD/modeling-app into max-click-delete-chamfers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! And I was able to test locally, both FT and GUI selection deletion worked well for me, it's really good to see 🥇
Description
This PR enables fillets and chamfers to be deleted through a point-and-click interface. Key updates include:
piped
andnon-piped
fillets and chamfers.unit
andPlaywright
tests for piped and non-piped scenarios.edgeTreatment
code module for better organization.Future Improvements
Note: These additional use cases have been added to the
Fillet UI
project and will be addressed in a separate PR.Closes: #5053