Remove STL import selection and storage options #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alteous
force-pushed
the
remove-stl-import-selection-and-storage
branch
from
ad4bb90 to
5cb2768
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
======================================
Coverage ? 9.17%
======================================
Files ? 18
Lines ? 730
Branches ? 0
======================================
Hits ? 67
Misses ? 663
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
adamchalmers
approved these changes
Dec 8, 2023
alteous
commented
Dec 8, 2023
| } | ||
|
|
||
| impl Default for Options { | ||
| fn default() -> Self { | ||
| Self { | ||
| coords: *coord::KITTYCAD, | ||
| selection: Default::default(), | ||
| storage: Default::default(), | ||
| units: UnitLength::Meters, |
There was a problem hiding this comment.
This was millimetres previously.
There was a problem hiding this comment.
I want to keep it as metres for now so I'll update the format tests accordingly.
|
Corresponding change to format: https://github.com/KittyCAD/format/pull/291 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6