-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
project to plane #587
Open
benjamaan476
wants to merge
8
commits into
main
Choose a base branch
from
ben/project_to_plane
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
project to plane #587
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
becbe6e
Added ProjectEntityToPlane endpoint
benjamaan476 7b75f12
typo
benjamaan476 ca797b4
better comment
benjamaan476 d51b449
Merge branch 'main' into ben/project_to_plane
benjamaan476 2c488e0
Add PartialEq and ts derives
benjamaan476 4ded8b5
Add ProjectPointsToPlane
benjamaan476 82f6551
Fix typo
benjamaan476 c87b372
Merge remote-tracking branch 'origin/main' into ben/project_to_plane
benjamaan476 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -809,6 +809,19 @@ | |
pub curve_id: Uuid, | ||
} | ||
|
||
/// Project an entity on to a plane. | ||
#[derive(Debug, Clone, Serialize, Deserialize, JsonSchema, ModelingCmdVariant)] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add |
||
pub struct ProjectEntityToPlane { | ||
/// Which entity to project (vertex or edge). | ||
pub entity_id: Uuid, | ||
/// Which plane to project entity_id onto. | ||
pub plane_id: Uuid, | ||
/// If true: the projected points are returned in the plane_id's coordinate system, | ||
/// else: the projected points are returned in the world coordinate system. | ||
pub use_plane_coords: bool, | ||
|
||
} | ||
|
||
/// Enum containing the variety of image formats snapshots may be exported to. | ||
#[derive(Debug, Clone, Serialize, Deserialize, JsonSchema, FromStr, Display)] | ||
#[serde(rename_all = "snake_case")] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use a bit more detail or an example of its use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An example or in the comments of the endpoint? Projecting a point onto a plane is where you calculate the normal between a plane and a point that does not lie on the plane. You then move that point along the normal until it is now lying on the plane exactly.
Useful for constraints, shadows, intersection testing, etc.p