Impl execution_plan::Value for many modeling command types #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchalmers
force-pushed
the
achalmers/derive-on-more
branch
from
8045e19 to
4ad0501
Compare
Finally, the macro is advanced enough to derive Value for the huge `OkModelingCmdResponse` enum! The only missing piece was that Vec<T: Value> didn't impl Value, but I've added that now.
adamchalmers
force-pushed
the
achalmers/derive-on-more
branch
from
4ad0501 to
d9d0dce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, the macro is advanced enough to derive Value for the huge
OkModelingCmdResponseenum! The only missing piece was thatVec<T: Value>didn't impl Value, but I've added that now.