Derive(ExecutionPlanValue) for enums #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
=======================================
Coverage ? 50.23%
=======================================
Files ? 33
Lines ? 2092
Branches ? 0
=======================================
Hits ? 1051
Misses ? 1041
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
adamchalmers
force-pushed
the
achalmers/derive-value-on-enum
branch
from
f22c6ae to
3ba61f8
Compare
adamchalmers
force-pushed
the
achalmers/derive-value-on-enum
branch
from
5e7042a to
62d13b9
Compare
Using the standard enum idiom. Some(v) becomes ["some"] followed by v's parts. None becomes just ["none"]
adamchalmers
force-pushed
the
achalmers/derive-value-on-enum
branch
6 times, most recently
from
3c02173 to
68519ba
Compare
adamchalmers
force-pushed
the
achalmers/derive-value-on-enum
branch
from
68519ba to
71dd6e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #42 I wrote a derive macro for
impl Valueon a struct type. Now the macro can be used on enum types too!