Move execution-plan types Value and Primitive into a new crate #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=======================================
Coverage ? 44.22%
=======================================
Files ? 32
Lines ? 1852
Branches ? 0
=======================================
Hits ? 819
Misses ? 1033
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
adamchalmers
force-pushed
the
achalmers/refactor-whole-crate-structure
branch
3 times, most recently
from
c9e0a5a to
0199c84
Compare
This way, modeling-cmds can import those types and implement the traits. In the future, I will write a derive macro for deriving Value on modeling-cmd types.
adamchalmers
force-pushed
the
achalmers/refactor-whole-crate-structure
branch
from
0199c84 to
7f9c988
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, modeling-cmds can import those types and implement the traits. In the future, I will write a derive macro for deriving Value on modeling-cmd types.