Use DeserializeOwned instead of Deserialize for ModelingCmdVariant #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deserialize<'de> lets your structs borrow their data from the serialized bytes/JSON string. But we aren't borrowing any data in our ModelingCmd. So we're having the downsides (wrangling lifetimes) without the upsides (efficient data). Right now it's fine for these structs to copy data so I'm going to use DeserializeOwned.
adamchalmers
force-pushed
the
achalmers/deserialize-owned-only
branch
from
d5d8330 to
f87cd5c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage ? 25.79%
=======================================
Files ? 28
Lines ? 1407
Branches ? 0
=======================================
Hits ? 363
Misses ? 1044
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deserialize<'de> lets your structs borrow their data from the serialized bytes/JSON string (for the lifetime 'de, i.e. the serialized bytes must live for 'de or longer). But we aren't borrowing any data in our ModelingCmd. So we're having the downsides (wrangling lifetimes) without the upsides (efficient data).
Right now it's fine for these structs to copy data so I'm going to use DeserializeOwned.