Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelingCmdVariant impl macro #31

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Conversation

adamchalmers
Copy link
Collaborator

@adamchalmers adamchalmers commented Dec 14, 2023

  • Add a new method to ModelingCmdVariant trait, fn name() which returns the command's name.
  • Add a macro for implementing ModelingCmdVariant
  • Add a macro for creating OkModelingCmdResponse
  • Add CONTRIBUTING.md

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@49df228). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage        ?   25.79%           
=======================================
  Files           ?       28           
  Lines           ?     1407           
  Branches        ?        0           
=======================================
  Hits            ?      363           
  Misses          ?     1044           
  Partials        ?        0           
Flag Coverage Δ
unittests 25.79% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gserena01 gserena01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super, super helpful! Approving now in case no changes are needed, but I'd love a response to the comments!

CONTRIBUTING.md Outdated Show resolved Hide resolved
modeling-cmds/src/impl_traits.rs Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
Copy link
Contributor

@gserena01 gserena01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for making contributions so much simpler!

@adamchalmers adamchalmers merged commit 5b206c3 into main Dec 14, 2023
8 checks passed
@adamchalmers adamchalmers deleted the achalmers/name-of-command branch December 14, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants