Skip to content

Comments

feat: add Visitor & VisitorMut to simply ScalarExpression visit#270

Merged
KKould merged 2 commits intomainfrom
feat/visitor
Jul 18, 2025
Merged

feat: add Visitor & VisitorMut to simply ScalarExpression visit#270
KKould merged 2 commits intomainfrom
feat/visitor

Conversation

@KKould
Copy link
Member

@KKould KKould commented Jul 18, 2025

What problem does this PR solve?

Using Visitor simplifies expression convenience

  • ConstantCalculator
  • Simplify
  • TryReference
  • BindEvaluator
  • HasCountStar

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould added the enhancement New feature or request label Jul 18, 2025
@KKould KKould self-assigned this Jul 18, 2025
@KKould KKould changed the title feat: add Visitor & 'VisitorMut' to simply ScalarExpression visit feat: add Visitor & VisitorMut to simply ScalarExpression visit Jul 18, 2025
@KKould KKould merged commit 1af504a into main Jul 18, 2025
9 of 12 checks passed
@KKould KKould deleted the feat/visitor branch July 21, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant