Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update planner_plugin parameters #199

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Update planner_plugin parameters #199

merged 2 commits into from
Dec 7, 2023

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Dec 6, 2023 •
edited
Loading

Blocked by moveit/moveit2#2457

Makes the planner plugin parameter a vector.

moriarty
moriarty previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@moriarty moriarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The upstream change which you said blocks this has been merged... lmk if this is ready to merge

@sjahr
Copy link
Contributor Author

sjahr commented Dec 7, 2023 •
edited
Loading

@moriarty It is merged upstream ✔️

@sjahr sjahr requested a review from moriarty December 7, 2023 18:57
@dyackzan dyackzan merged commit 915df14 into Kinovarobotics:main Dec 7, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyackzan dyackzan dyackzan approved these changes

@moriarty moriarty Awaiting requested review from moriarty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjahr @moriarty @dyackzan